Skip to content

Conversation

@romanzdk
Copy link

@romanzdk romanzdk commented Nov 6, 2023

Add an example how to reference AWS connection in jinja template


@boring-cyborg
Copy link

boring-cyborg bot commented Nov 6, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 23, 2023
@github-actions github-actions bot closed this Dec 28, 2023
@romanzdk
Copy link
Author

romanzdk commented Jan 3, 2024

Could someone merge this, please?

@potiuk
Copy link
Member

potiuk commented Jan 3, 2024

First we need to reopen and see if it still workf

@potiuk potiuk reopened this Jan 3, 2024
@potiuk
Copy link
Member

potiuk commented Jan 3, 2024

BTW. It's up to author to remind and follow up if you see your PR is not merged (and especially when bot marks it as stalled) - it's far easier to do it for. you than for reviewers to monitor 170+ PRs that are on average open.

See some more information about it in - you are read a bit more about the review/merge process here https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#step-5-pass-pr-review

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 3, 2024
@romanzdk
Copy link
Author

romanzdk commented Feb 8, 2024

May I ask for merging this MR, please?

@potiuk
Copy link
Member

potiuk commented Feb 8, 2024

Well. You have docs and spellchecking failing. In order to merge PR it needs to be green.

Also merging it now when you are 1000 commits behind is risky, you should rebase it.

Screenshot 2024-02-08 at 22 37 11

@ferruzzi
Copy link
Contributor

May just be me, but I read this change and I have no idea where to put those two lines or how to use them.

@github-actions
Copy link

github-actions bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 3, 2024
@github-actions github-actions bot closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation provider:amazon AWS/Amazon - related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants