Remove FAB related auth methods from security manager to auth manager#35515
Merged
potiuk merged 2 commits intoapache:mainfrom Nov 9, 2023
Merged
Remove FAB related auth methods from security manager to auth manager#35515potiuk merged 2 commits intoapache:mainfrom
potiuk merged 2 commits intoapache:mainfrom
Conversation
vincbeck
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
o-nikolas
approved these changes
Nov 8, 2023
potiuk
approved these changes
Nov 9, 2023
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Nov 10, 2023
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all FAB related methods/properties from
airflow.www.security_manager.AirflowSecurityManagerV2toairflow.auth.managers.fab.security_manager.override.FabAirflowSecurityManagerOverride. This is the last PR of the many that had been already merged forAirflowSecurityManagerV2. This security manager no longer contain any FAB auth related logic.Nothing new here, code is just being moved.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.