Add parameter confirm to GCSToSFTPOperator#35704
Add parameter confirm to GCSToSFTPOperator#35704Nimo139 wants to merge 6 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
I think we will need a (really small) unit test for that one |
|
Hey @Nimo139 do you have time to complete this PR? |
|
Sorry for the late reply, I didn't have time to set up the test environment during the holidays. I have now adjusted the tests for the parameter so that they pass. I have added a very basic test. If you have any better suggestions on how to test it with the mocks, I am glad to hear them. |
|
Should be good enough - now the only thing left is to rebase to latest |
|
I fixed the static tests but there is a failure with one of the unit tests that you need to look into @Nimo139 |
b0b7f61 to
bb0d9f3
Compare
Co-authored-by: Pankaj Singh <98807258+pankajastro@users.noreply.github.com>
|
Sorry for the force-push, I accidentally updated without clicking the rebase option. I hope you can still use the PR. |
| ) | ||
| self.jar = jar | ||
| self.job_class = job_class | ||
| self.pipeline_options.setdefault("labels", {}).update( |
There was a problem hiding this comment.
Is this change related to the PR?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
If the SFTP server picks up the file immediately Paramiko cannot check the file size.
The current operator terminates with a fail after the transfer because the file cannot be found.