Skip to content

Comments

Add parameter confirm to GCSToSFTPOperator#35704

Closed
Nimo139 wants to merge 6 commits intoapache:mainfrom
Nimo139:main
Closed

Add parameter confirm to GCSToSFTPOperator#35704
Nimo139 wants to merge 6 commits intoapache:mainfrom
Nimo139:main

Conversation

@Nimo139
Copy link

@Nimo139 Nimo139 commented Nov 17, 2023

If the SFTP server picks up the file immediately Paramiko cannot check the file size.
The current operator terminates with a fail after the transfer because the file cannot be found.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 17, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 17, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Nov 17, 2023

I think we will need a (really small) unit test for that one

@eladkal
Copy link
Contributor

eladkal commented Dec 28, 2023

Hey @Nimo139 do you have time to complete this PR?

@Nimo139
Copy link
Author

Nimo139 commented Jan 7, 2024

Sorry for the late reply, I didn't have time to set up the test environment during the holidays. I have now adjusted the tests for the parameter so that they pass. I have added a very basic test. If you have any better suggestions on how to test it with the mocks, I am glad to hear them.

@potiuk
Copy link
Member

potiuk commented Jan 7, 2024

Should be good enough - now the only thing left is to rebase to latest main and fix failing static checks

@eladkal
Copy link
Contributor

eladkal commented Jan 10, 2024

I fixed the static tests but there is a failure with one of the unit tests that you need to look into @Nimo139
FAILED tests/providers/apache/beam/operators/test_beam.py::TestBeamRunJavaPipelineOperator::test_exec_dataflow_runner - AssertionError: expected call not found.
https://github.com/apache/airflow/actions/runs/7443638524/job/20248835783?pr=35704#step:5:1100

@Nimo139 Nimo139 force-pushed the main branch 2 times, most recently from b0b7f61 to bb0d9f3 Compare January 13, 2024 23:29
@Nimo139
Copy link
Author

Nimo139 commented Jan 13, 2024

Sorry for the force-push, I accidentally updated without clicking the rebase option. I hope you can still use the PR.
The beam unit test should now pass.

)
self.jar = jar
self.job_class = job_class
self.pipeline_options.setdefault("labels", {}).update(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to the PR?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 29, 2024
@github-actions github-actions bot closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants