Skip to content

Fix DataFusion example type annotations#35753

Merged
eladkal merged 1 commit intoapache:mainfrom
Taragolis:datafusion-example-annotation
Nov 21, 2023
Merged

Fix DataFusion example type annotations#35753
eladkal merged 1 commit intoapache:mainfrom
Taragolis:datafusion-example-annotation

Conversation

@Taragolis
Copy link
Copy Markdown
Contributor

@Taragolis Taragolis commented Nov 20, 2023

I've got this error/warning during breeze static-checks mypy-providers --all-files during non related to this provider changes.

tests/system/providers/google/cloud/datafusion/example_datafusion.py:322: note: "__call__" is considered instance variable, to make it class variable use ClassVar[...]
tests/system/providers/google/cloud/datafusion/example_datafusion.py:322: note: Error code "misc" not covered by "type: ignore" comment

I guess this happen due to wrong type annotation for Task Flow operator


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 20, 2023
@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Nov 20, 2023
@eladkal eladkal merged commit 67ebc3a into apache:main Nov 21, 2023
@Taragolis Taragolis deleted the datafusion-example-annotation branch November 21, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers area:system-tests provider:google Google (including GCP) related issues type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants