[AIRFLOW-2723] - Update lxml dependancy to >= 4.0.0#3583
Closed
neil90-db wants to merge 1 commit intoapache:masterfrom
neil90-db:master
Closed
[AIRFLOW-2723] - Update lxml dependancy to >= 4.0.0#3583neil90-db wants to merge 1 commit intoapache:masterfrom neil90-db:master
neil90-db wants to merge 1 commit intoapache:masterfrom
neil90-db:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3583 +/- ##
==========================================
- Coverage 76.83% 76.83% -0.01%
==========================================
Files 204 204
Lines 15492 15492
==========================================
- Hits 11904 11903 -1
- Misses 3588 3589 +1
Continue to review full report at Codecov.
|
Contributor
|
The issue seems to be with your machine: https://pastebin.com/30AJz5tC It looks like it is compiling some C-extensions used by lxml. Apart from that I don't see any objects to update this to a more recent version. |
Contributor
Author
|
@Fokko, So this is using the base Python3 Docker image. So must be a dependency missing on the Python3 image? |
Contributor
|
It works on my machine: |
Contributor
|
I ran into this issue yesterday as well, it is because the Airflow docs suggest to run with |
Contributor
Author
|
So if anything this just helps Airflow be compatible with Python 3.7 |
Contributor
|
Exactly. Good to know: |
Fokko
pushed a commit
to Fokko/incubator-airflow
that referenced
this pull request
Aug 8, 2018
Closes apache#3583 from neil90/master
lxneng
pushed a commit
to lxneng/incubator-airflow
that referenced
this pull request
Aug 10, 2018
Closes apache#3583 from neil90/master
galak75
pushed a commit
to VilledeMontreal/incubator-airflow
that referenced
this pull request
Nov 23, 2018
Closes apache#3583 from neil90/master
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
Closes apache#3583 from neil90/master
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Jan 23, 2019
Closes apache#3583 from neil90/master
Zylphrex
added a commit
to Zylphrex/incubator-airflow
that referenced
this pull request
May 23, 2019
[AIRFLOW-2713] Rename async variable in setup.py for Python 3.7.0 compatibility Closes apache#3561 from Perados/rename-async-to-async_packages-in-setup [AIRFLOW-2716] Replace async and await py3.7 keywords Closes apache#3578 from JacobHayes/py37-keywords [AIRFLOW-2723] Update lxml dependancy to >= 4.0.0 Closes apache#3583 from neil90/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
JIRA
Description
Tests
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff