Skip running "fix ownership" when Breeze image pre-commits are skipped#35859
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 26, 2023
Conversation
When we skip breeze image pre-commits, we do not have breeze image available, because we want to run them as fast as possible. In this case we should not attempt to run "ownership fixing" - because: a) it reuires the image b) the whole point is to fix ownership of files created as side effect of breeze-image run commands This means that we do not need it and it slows down static checks on PRs that do not require breeze image to be created.
Member
Author
|
This is why "basic static checks" in https://github.com/apache/airflow/actions/runs/6995199303/job/19029787821?pr=35858#step:8:183 took 1m32 seconds instead of 30 seconds. |
hussein-awala
approved these changes
Nov 26, 2023
potiuk
deleted the
do-not-run-fix-onwership-when-image-pre-commits-are-skipped
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we skip breeze image pre-commits, we do not have breeze image available, because we want to run them as fast as possible. In this case we should not attempt to run "ownership fixing" - because: a) it reuires the image
b) the whole point is to fix ownership of files created as side
effect of breeze-image run commands
This means that we do not need it and it slows down static checks on PRs that do not require breeze image to be created.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.