Skip to content

Slack: Remove parameter token in SlackAPIPostOperator's docstring#36121

Merged
hussein-awala merged 1 commit intoapache:mainfrom
brienzb:brienzbSlackAPIPostOperator-fix
Dec 8, 2023
Merged

Slack: Remove parameter token in SlackAPIPostOperator's docstring#36121
hussein-awala merged 1 commit intoapache:mainfrom
brienzb:brienzbSlackAPIPostOperator-fix

Conversation

@brienzb
Copy link
Copy Markdown
Contributor

@brienzb brienzb commented Dec 8, 2023

Since Slack provider 8.0 version and later, parameter token has been deleted.
Related commit: ed6a4fd


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Dec 8, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Taragolis Taragolis added the type:doc-only Changelog: Doc Only label Dec 8, 2023
@Taragolis Taragolis changed the title Slack: Remove parameter token in SlackAPIPostOperator Slack: Remove parameter token in SlackAPIPostOperator's docstring Dec 8, 2023
@hussein-awala hussein-awala merged commit 4824ca7 into apache:main Dec 8, 2023
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Dec 8, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@hussein-awala
Copy link
Copy Markdown
Member

Congrats on your first commit 🎉

@brienzb brienzb deleted the brienzbSlackAPIPostOperator-fix branch December 9, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants