Skip to content

Remove duplicate dropdown entry in providers issue template#36180

Closed
josh-fell wants to merge 1 commit intoapache:mainfrom
josh-fell:provider-bug-template
Closed

Remove duplicate dropdown entry in providers issue template#36180
josh-fell wants to merge 1 commit intoapache:mainfrom
josh-fell:provider-bug-template

Conversation

@josh-fell
Copy link
Contributor

Because there is a duplicate option in the "Apache Airflow Provider(s)" dropdown, the "Airflow Providers Bug report" template is not available for users to select when logging a bug.

Because there is a duplicate option in the "Apache Airflow Provider(s)" dropdown, the template is not available for users to select when logging a bug.
@pateash
Copy link
Contributor

pateash commented Dec 12, 2023

thanks @josh-fell ,
we should also make sure that the list is sorted whenever we add a new entry going forward

Copy link
Contributor

@pateash pateash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you please add a comment like this on the top of the list, this will help contributors going forward
# Please make sure to have these options sorted to avoid duplicates

@josh-fell
Copy link
Contributor Author

josh-fell commented Dec 12, 2023

we should also make sure that the list is sorted whenever we add a new entry going forward

Agreed. The duplicated entry check and sort of the list could be add in the "Validate provider.yaml files" CI check. This would be more "enforceable" than a comment in the template.

Since this missing template is user-facing and helps with issue triage (instead of folks logging issues under the Airflow bug template), I thought this was a quick win for expediency and then work on the pre-commit check later.

@josh-fell josh-fell added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 12, 2023
@potiuk
Copy link
Member

potiuk commented Dec 12, 2023

Added pre-commit as quick fix (with some more fixes it turned out): #36183

@potiuk
Copy link
Member

potiuk commented Dec 12, 2023

Closing in favour of merged #36183

@josh-fell
Copy link
Contributor Author

I had a feeling that the very mention of "we should add this to CI" would trigger a Jarek-special PR. 😄

@josh-fell josh-fell closed this Dec 12, 2023
@josh-fell josh-fell deleted the provider-bug-template branch December 12, 2023 18:18
@josh-fell
Copy link
Contributor Author

Thanks for whipping that up @potiuk!

@potiuk
Copy link
Member

potiuk commented Dec 12, 2023

I had a feeling that the very mention of "we should add this to CI" would trigger a Jarek-special PR. 😄

Very much so :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants