Sync v2-8-stable with v2-8-test to release 2.8.0#36212
Merged
ephraimbuddy merged 1 commit intov2-8-stablefrom Dec 13, 2023
Merged
Sync v2-8-stable with v2-8-test to release 2.8.0#36212ephraimbuddy merged 1 commit intov2-8-stablefrom
ephraimbuddy merged 1 commit intov2-8-stablefrom
Conversation
Older providers do not have a get_fs method that takes storage_options as arguments. If we encounter such provider and storage_options are passed we should error out instead if silently ignoring. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 6c94ddf)
ephraimbuddy
requested review from
bolkedebruin,
kaxil,
phanikumv and
potiuk
and removed request for
bolkedebruin
potiuk
approved these changes
Dec 13, 2023
pankajkoti
approved these changes
Dec 13, 2023
bolkedebruin
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time for
2.8.0rc3!