Bugfix/fix Non DB - WWW and Always tests#36258
Merged
potiuk merged 1 commit intoapache:mainfrom Dec 16, 2023
Merged
Conversation
romsharon98
force-pushed
the
bugfix/fix-failing-tests
branch
from
f015d11 to
22c4768
Compare
romsharon98
changed the title
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Nice! I tried fixing it without fixtures but did not find a solution. Let's see what @potiuk thinks about this solution.
potiuk
approved these changes
Dec 16, 2023
Member
|
Very nice! We should likely also add an example of it to the docs :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a bug when creating object the use sqlalchemy inside paramtrize.
move creation of object that depends on sqlalchemy into fixtures
u can find more in this documentation
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.