Fix few caveats in provider release process#36264
Merged
potiuk merged 1 commit intoapache:mainfrom Dec 17, 2023
Merged
Conversation
There were few small problems in release process:
1) When the SVN directories were in symbolically linked directories, svn
got into locked directory status
2) Cleaning old relases failed to find the files in current directory,
because breeze changes working directory before running and the `.`
directory was really `airflow` repository, thus no released artifacts
could be found.
3) When the old releases contained `_` rather thatn `-` (as it was
in the bdist_wheel prepared packages) then we failed to delet the
files because the file names for them were constructed from the
normalized file names (with `-`).
This PR fixes those problems:
1) `VAR=$(pwd -P)` is used in order to resolve potentially symbolically
linked urrent working directory and `cd ${VAR}` is used to switch dir
to them
2) The same `$(pwd -P)` is used to pass the directory to the
clean-old-provider-artifacts command to avoid interpreting `.` as
"AIRFLOW_ROOT" directory.
3) Filen name is stored in FileVersion and used to run actual `svn rm`
command - this way the right file name will be used, regardless from
normalization of the package names.
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
pierrejeambrun
as code owners
potiuk
requested review from
amoghrajesh
and removed request for
ashb,
jedcunningham,
kaxil and
pierrejeambrun
potiuk
changed the title
pierrejeambrun
approved these changes
Dec 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were few small problems in release process:
got into locked directory status
because breeze changes working directory before running and the
.directory was really
airflowrepository, thus no released artifactscould be found.
_rather thatn-(as it wasin the bdist_wheel prepared packages) then we failed to delet the
files because the file names for them were constructed from the
normalized file names (with
-).This PR fixes those problems:
VAR=$(pwd -P)is used in order to resolve potentially symbolicallylinked urrent working directory and
cd ${VAR}is used to switch dirto them
$(pwd -P)is used to pass the directory to theclean-old-provider-artifacts command to avoid interpreting
.as"AIRFLOW_ROOT" directory.
svn rmcommand - this way the right file name will be used, regardless from
normalization of the package names.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.