Skip to content

Comments

Remove additional generation of dependencies when building CI images#36282

Closed
potiuk wants to merge 1 commit intoapache:mainfrom
potiuk:fix-generated-dependencies-script
Closed

Remove additional generation of dependencies when building CI images#36282
potiuk wants to merge 1 commit intoapache:mainfrom
potiuk:fix-generated-dependencies-script

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 18, 2023

When generated dependencies are not properly updated, we had a special step where the dependencies were generated "just in case" before CI image was built, because otherwise building the CI image could have failed with strange "failed because of conflicting dependencies" without a clue what was the root cause.

However, the pre-commit did not return error exit code - because for the pre-commit, it is enough that a file is modified during pre-commit to fail the pre-commit in general.

That had a nasty side effect because the built CI image actually already contained properly generated dependencies (by this step), and it did not properly detected cases where the ones in the repository were added manually and not generated with pre-commit.

This PR fixes it - instead of generating and building such image in CI it will now fail the CI image building step but with clear instructions what to do.

The CI job step uses now regular breeze command rather than running the script manually but also the script returns error code in case the generated dependencies have been updated.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When generated dependencies are not properly updated, we had a special
step where the dependencies were generated "just in case" before CI
image was built, because otherwise building the CI image could have
failed with strange "failed because of conflicting dependencies"
without a clue what was the root cause.

However, the pre-commit did not return error exit code - because for the
pre-commit, it is enough that a file is modified during pre-commit to
fail the pre-commit in general.

That had a nasty side effect because the built CI image actually already
contained properly generated dependencies (by this step), and it did not
properly detected cases where the ones in the repository were added
manually and not generated with pre-commit.

This PR fixes it - instead of generating and building such image in
CI it will now fail the CI image building step but with clear
instructions what to do.

The CI job step uses now regular breeze command rather than running
the script manually but also the script returns error code in case
the generated dependencies have been updated.
@potiuk
Copy link
Member Author

potiuk commented Dec 18, 2023

actually I need to close that one. I need to run it from the "airflow" repo to test it properly.

@potiuk potiuk closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant