Skip to content

Increase ConflictException retries to 4 total#36337

Merged
potiuk merged 3 commits intoapache:mainfrom
aws-mwaa:onikolas/sagemaker_conflict_exeception_retry_increase
Dec 21, 2023
Merged

Increase ConflictException retries to 4 total#36337
potiuk merged 3 commits intoapache:mainfrom
aws-mwaa:onikolas/sagemaker_conflict_exeception_retry_increase

Conversation

@o-nikolas
Copy link
Contributor

We have seen a recent uptick in ConflictExceptions we receive from SageMaker. It's not many, but enough to fail our system tests unnecessarily.

Bumping the retires to 4 which I still think is very reasonable, considering it's a very tight loop of 0.3 seconds sleep per retry.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We have seen a recent uptick in ConflictExceptions we receive from
SageMaker. It's not many, but enough to fail our system tests
unnecessarily.

Bumping the retires to 4 which I still think is very reasonable,
considering it's a very tight loop of 0.3 seconds sleep per retry.
@o-nikolas o-nikolas requested a review from eladkal as a code owner December 20, 2023 21:35
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Dec 20, 2023
@potiuk
Copy link
Member

potiuk commented Dec 21, 2023

And test needs fixing :(

o-nikolas and others added 2 commits December 21, 2023 10:38
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants