Add libxml2 install command for macOS in contributor quick start doc#36388
Merged
hussein-awala merged 2 commits intoapache:mainfrom Dec 23, 2023
Merged
Add libxml2 install command for macOS in contributor quick start doc#36388hussein-awala merged 2 commits intoapache:mainfrom
hussein-awala merged 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
701c000 to
2216a27
Compare
Taragolis
reviewed
Dec 23, 2023
Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is>
Taragolis
approved these changes
Dec 23, 2023
hussein-awala
approved these changes
Dec 23, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Member
|
Congrats on your first commit 🎉 |
Contributor
Author
@hussein-awala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The both documents below states that libxml2 should be installed as a required package for the pre-commit hook.
While the first document includes installation commands for both Linux and Mac, the next document lacks instructions for Mac. So, I have added the Mac installation commands here.
https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks
https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#configuring-pre-commit
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.