Optimise getting changelogs in airflow-github#36548
Conversation
|
Can you test by running it between v2-7-stable and v2-8-stable. Problem was between minors |
|
Sure @ephraimbuddy, let me check that out and I will post the results here |
|
@ephraimbuddy there was a bug in the code and I managed to fix it now after some debugging. The issue was that the non core commits were getting included due to faulty else condition. Managed to test between origin/v2-7-stable and origin/v2-8-stable. Results:
The diff is due to different log message, not any actual diff. |
|
The new approach also saves a hell lot of time actually :) |
|
@ephraimbuddy - WDYT? |
|
Gentle bump on this one @ephraimbuddy |
|
Thank you. Sending this one in, since it is a simple fix. Thanks @potiuk @ephraimbuddy @Lee-W for the reviews |
(cherry picked from commit 142c737)
(cherry picked from commit 142c737)

Fix the logic for getting changelog in minor versions so that we get only the changelog that is not present in the RELEASE_NOTES.rst instead of getting everything which is a heavy operation.
How was this tested?
./airflow-github changelog origin/v1-8-stable origin/v1-8-test > without-changes./airflow-github changelog origin/v1-8-stable origin/v1-8-test > with-changesgit diff --no-index with-changes without-changes^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.