[AIRFLOW-2825]Fix S3ToHiveTransfer bug due to case#3665
Merged
Fokko merged 1 commit intoapache:masterfrom Jul 31, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3665 +/- ##
==========================================
- Coverage 77.51% 77.51% -0.01%
==========================================
Files 205 205
Lines 15751 15751
==========================================
- Hits 12210 12209 -1
- Misses 3541 3542 +1
Continue to review full report at Codecov.
|
Member
|
could you add a test? |
50e9dff to
4413ea6
Compare
Because upper/lower case was not considered in the file extension check, S3ToHiveTransfer operator may mistakenly think a GZIP file with uppercase ext ".GZ" is not a GZIP file and raise exception.
Member
Author
|
Hi @feng-tao, thanks for suggesting this. I have updated the related test. Instead of adding separate testing items, I updated the existing ones. |
Contributor
|
LGTM, thanks @XD-DENG |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
Description
Because upper/lower case was not considered in the file extension check, S3ToHiveTransfer operator may mistakenly think a GZIP file with uppercase ext ".GZ" (or ".gZ", ".Gz") is not a GZIP file and raise exception.
Tests
Commits
Documentation
Code Quality
git diff upstream/master -u -- "*.py" | flake8 --diff