Update test_file_not_new_enough with logical_date example#36681
Closed
fpopic wants to merge 4 commits intoapache:mainfrom
Closed
Update test_file_not_new_enough with logical_date example#36681fpopic wants to merge 4 commits intoapache:mainfrom
fpopic wants to merge 4 commits intoapache:mainfrom
Conversation
fpopic
changed the title
fpopic
changed the title
dirrao
requested changes
Jan 10, 2024
Contributor
There was a problem hiding this comment.
Static checks are failing. I would recommend to use pre-commit checks.
https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst
| @@ -86,16 +86,15 @@ def test_file_new_enough(self, sftp_hook_mock): | |||
|
|
|||
| @patch("airflow.providers.sftp.sensors.sftp.SFTPHook") | |||
| def test_file_not_new_enough(self, sftp_hook_mock): | |||
Contributor
There was a problem hiding this comment.
It male sense to update for the test_file_new_enough test case as well.
Contributor
Author
There was a problem hiding this comment.
Yes, once the solution to #36629 is found can update.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
fpopic
changed the title
fpopic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #36629
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.