Skip to content

Revert [AIRFLOW-2814] - Change min_file_process_interval to 0#3669

Merged
kaxil merged 1 commit intomasterfrom
revert-2814
Aug 3, 2018
Merged

Revert [AIRFLOW-2814] - Change min_file_process_interval to 0#3669
kaxil merged 1 commit intomasterfrom
revert-2814

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Jul 31, 2018

Make sure you have checked all steps below.

JIRA

  • My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@kaxil
Copy link
Member Author

kaxil commented Jul 31, 2018

@Fokko PTAL. Also, shouldn't we be reducing dag_dir_list_interval as well? It is 5 mins by default.

@XD-DENG
Copy link
Member

XD-DENG commented Jul 31, 2018

Hi @kaxil , please be reminded to update the comment in
https://github.com/apache/incubator-airflow/blob/master/airflow/jobs.py#L592 as well, otherwise the comment will be inconsistent with the configuration value again.

@codecov-io
Copy link

Codecov Report

Merging #3669 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3669      +/-   ##
==========================================
+ Coverage   77.51%   77.79%   +0.27%     
==========================================
  Files         205      205              
  Lines       15751    16079     +328     
==========================================
+ Hits        12210    12508     +298     
- Misses       3541     3571      +30
Impacted Files Coverage Δ
airflow/jobs.py 84.63% <ø> (+1.88%) ⬆️
airflow/utils/dag_processing.py 89.45% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed97204...1ee1fc4. Read the comment docs.

@kaxil
Copy link
Member Author

kaxil commented Aug 2, 2018

@Fokko @feng-tao Can you please take a look?

@kaxil kaxil requested a review from Fokko August 2, 2018 19:46
@feng-tao
Copy link
Member

feng-tao commented Aug 3, 2018

@kaxil , lgtm

@kaxil kaxil merged commit 758be9d into master Aug 3, 2018
@kaxil kaxil deleted the revert-2814 branch August 3, 2018 08:27
lxneng pushed a commit to lxneng/incubator-airflow that referenced this pull request Aug 10, 2018
…he#3669)

- Change the time (in seconds) after which a new DAG should be picked up from the filesystem
kaxil added a commit that referenced this pull request Nov 29, 2018
- Change the time (in seconds) after which a new DAG should be picked up from the filesystem
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
…he#3669)

- Change the time (in seconds) after which a new DAG should be picked up from the filesystem
kaxil added a commit that referenced this pull request Jan 9, 2019
- Change the time (in seconds) after which a new DAG should be picked up from the filesystem
ashb pushed a commit to ashb/airflow that referenced this pull request Jan 10, 2019
…he#3669)

- Change the time (in seconds) after which a new DAG should be picked up from the filesystem
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Jan 23, 2019
…he#3669)

- Change the time (in seconds) after which a new DAG should be picked up from the filesystem
@kaxil
Copy link
Member Author

kaxil commented Apr 12, 2019

This revert was based in discussion at #3659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants