check query status before SnowflakeSqlApiOperator execute in deferrable mode#36850
Merged
phanikumv merged 3 commits intoapache:mainfrom Jan 18, 2024
Conversation
boring-cyborg
bot
added
area:providers
provider:snowflake
dirrao
requested changes
Jan 18, 2024
Contributor
dirrao
left a comment
dirrao
left a comment
There was a problem hiding this comment.
Nice work. Snowflake test cases are failing. Can you check and fix them?
Contributor
Author
fixed |
phanikumv
force-pushed
the
check-query-status-before-SnowflakeSqlApiOperator-execute-in-deferrable-mode
branch
from
c12079c to
bdc42e0
Compare
Lee-W
approved these changes
Jan 18, 2024
vatsrahul1001
force-pushed
the
check-query-status-before-SnowflakeSqlApiOperator-execute-in-deferrable-mode
branch
from
bdc42e0 to
e3a4a20
Compare
phanikumv
approved these changes
Jan 18, 2024
phanikumv
deleted the
check-query-status-before-SnowflakeSqlApiOperator-execute-in-deferrable-mode
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses checking the status of the query before deferring the task to the triggerer.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.