Merged
Conversation
Contributor
|
Hi @m1racoli @Lee-W @pankajastro ! |
98c1983 to
2d6bda5
Compare
2d6bda5 to
a37134a
Compare
dirrao
requested changes
Jan 23, 2024
Contributor
dirrao
left a comment
There was a problem hiding this comment.
Existing test cases failing. Proposed a change to fix it.
Co-authored-by: Gopal Dirisala <39794726+dirrao@users.noreply.github.com>
Lee-W
approved these changes
Jan 24, 2024
potiuk
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a small fix that adds missing scopes into a token.
Relates to #34727 and continues #36849, #36903.
In our use case we have a DAG (see below) with
BigQueryInsertJobOperatorwith the following characteristics:In this case instantiation of the newly implemented class _CredentialsToken fails with exception raise in the base class:
Current PR simply passes hook scopes into the
_CredentialsToken, so the base classTokenwould work properly.DAG