Automatically upgrade various components in canary builds#37113
Merged
potiuk merged 1 commit intoapache:mainfrom Jan 31, 2024
Merged
Automatically upgrade various components in canary builds#37113potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
Taragolis,
dstandish,
eladkal,
josh-fell and
pankajkoti
potiuk
force-pushed
the
upgrade-build-dependencies
branch
4 times, most recently
from
6a27259 to
9a2b003
Compare
Member
Author
|
OK. Should be ready for review. It won't run in regular PR - only in canary builds, but I commented the if and it nicely works https://github.com/apache/airflow/actions/runs/7723217069/job/21052882896?pr=37113 This way we will know when we should do |
Member
Author
|
cc: @Taragolis - that's what I recently explained that we need to have :) |
Taragolis
reviewed
Jan 31, 2024
Taragolis
reviewed
Jan 31, 2024
This change attempts to automatically upgrade our dependencies in the canary builds. This means that canary builds will fail occasionally when there is a need to update some dependencies that otherwise are not updated automatically. This gives an opportunity to fix such failing main build as soon as it happns. It does not impact generation of constraints or building the cache, the only sign that things are wrong is failing canary build, so impact to it should be minimal - we will either see the main build failing after merge, or we will fix it alongside with fixing some other reason for main failing (such us broken dependencies) Currently, the following upgrades are done in canary build: * Upgrading pre-commits * Upgrading black version * Upgrading build pinned dependencies
potiuk
force-pushed
the
upgrade-build-dependencies
branch
from
9a2b003 to
7d879aa
Compare
Taragolis
approved these changes
Jan 31, 2024
potiuk
added a commit
that referenced
this pull request
Feb 7, 2024
This change attempts to automatically upgrade our dependencies in the canary builds. This means that canary builds will fail occasionally when there is a need to update some dependencies that otherwise are not updated automatically. This gives an opportunity to fix such failing main build as soon as it happns. It does not impact generation of constraints or building the cache, the only sign that things are wrong is failing canary build, so impact to it should be minimal - we will either see the main build failing after merge, or we will fix it alongside with fixing some other reason for main failing (such us broken dependencies) Currently, the following upgrades are done in canary build: * Upgrading pre-commits * Upgrading black version * Upgrading build pinned dependencies (cherry picked from commit b14dbf2)
potiuk
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
This change attempts to automatically upgrade our dependencies in the canary builds. This means that canary builds will fail occasionally when there is a need to update some dependencies that otherwise are not updated automatically. This gives an opportunity to fix such failing main build as soon as it happns. It does not impact generation of constraints or building the cache, the only sign that things are wrong is failing canary build, so impact to it should be minimal - we will either see the main build failing after merge, or we will fix it alongside with fixing some other reason for main failing (such us broken dependencies) Currently, the following upgrades are done in canary build: * Upgrading pre-commits * Upgrading black version * Upgrading build pinned dependencies (cherry picked from commit b14dbf2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change attempts to automatically upgrade our dependencies in the canary builds. This means that canary builds will fail occasionally when there is a need to update some dependencies that otherwise are not updated automatically. This gives an opportunity to fix such failing main build as soon as it happns.
It does not impact generation of constraints or building the cache, the only sign that things are wrong is failing canary build, so impact to it should be minimal - we will either see the main build failing after merge, or we will fix it alongside with fixing some other reason for main failing (such us broken dependencies)
With this change, the following upgrades are done in canary build:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.