Fix unexpected keyword argument 'secret_path' in secrets.kv.v2#37626
Fix unexpected keyword argument 'secret_path' in secrets.kv.v2#37626hussein-awala merged 2 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
hussein-awala
left a comment
There was a problem hiding this comment.
It seems no one uses this method in the hook, the bug has been around for years with no reported issues.
98504dc to
b3d4d8d
Compare
I was planning on using it, otherwise I wouldn't have encountered the bug 😉 |
Closes: #37619
Fix unexpected keyword argument 'secret_path' in secrets.kv.v2
Called
self.client.secrets.kv.v2.create_or_update_secret()function withpathargument insteadDocument: https://hvac.readthedocs.io/en/stable/usage/secrets_engines/kv_v2.html#create-update-secret
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.