Fix passing packages using arguments#37636
Merged
potiuk merged 1 commit intoapache:mainfrom Feb 22, 2024
Merged
Conversation
potiuk
requested review from
Lee-W,
amoghrajesh,
ashb,
eladkal,
hussein-awala and
jedcunningham
and removed request for
ashb and
jedcunningham
The apache#37502 added --package-list option to prepare-provider-packages and publish-docs release management command, but in cases packages were passed by arguments it actually generated empty list of packages and all packages were attempted to be created. Only those ready to be released were prepared, but all of them. This PR fixes it.
potiuk
force-pushed
the
handle-packages-selected-by-arguments-back
branch
from
a6f6eb5 to
ca87e2a
Compare
potiuk
commented
Feb 22, 2024
jedcunningham
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #37502 added --package-list option to prepare-provider-packages and publish-docs release management command, but in cases packages were passed by arguments it actually generated empty list of packages and all packages were attempted to be created. Only those ready to be released were prepared, but all of them.
This PR fixes it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.