Skip to content

Allow templating git-sync repo url#37661

Closed
kimminw00 wants to merge 1 commit intoapache:mainfrom
kimminw00:feature/allow-templating-git-sync-repo-url
Closed

Allow templating git-sync repo url#37661
kimminw00 wants to merge 1 commit intoapache:mainfrom
kimminw00:feature/allow-templating-git-sync-repo-url

Conversation

@kimminw00
Copy link
Contributor

@kimminw00 kimminw00 commented Feb 23, 2024

I would like to propose allowing template values to git-sync repo url.

Why is it needed?
Let's assume that we're providing airflow service to multiple teams.
By creating git-sync repo urls using {{ .Release.Namespace }} or {{ .Release.Name }},
there is no need to create multiple values ​​files to store different hostnames ​​for each team.

Usage

dags:
  gitSync:
    enabled: true

    # git repo clone url (can be templated)
    repo: 'https://github.com/{{ .Release.Namespace }}/airflow-dags.git'

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Feb 23, 2024
@kimminw00 kimminw00 force-pushed the feature/allow-templating-git-sync-repo-url branch from 9a933e4 to 9e1a4af Compare February 23, 2024 17:26
@kimminw00 kimminw00 force-pushed the feature/allow-templating-git-sync-repo-url branch from 9e1a4af to 5818c0c Compare February 23, 2024 17:36
@kimminw00 kimminw00 closed this Feb 23, 2024
@jedcunningham
Copy link
Member

@kimminw00, did you intend to close this?

@kimminw00
Copy link
Contributor Author

@kimminw00, did you intend to close this?

I found a problem with my code.
So I will reopen it again after editing the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants