Protect against the case where Airflow is checked out in AIRFLOW_HOME#37697
Merged
potiuk merged 1 commit intoapache:mainfrom Feb 26, 2024
Merged
Conversation
When airflow is checked out in the same directory as AIRFLOW_HOME,
cleanup might remove everythig including .git folder. And this might
happen because people might check out airflow in their HOME
directory - and default AIRFLOW_HOME is ${HOME}/airflow.
THis PR will detect if Airflow is checked out AIRFLOW_HOME and
will error out in this case.
Member
Author
|
This is what the user will see: 
|
eladkal
approved these changes
Feb 26, 2024
Taragolis
approved these changes
Feb 26, 2024
potiuk
deleted the
protect-against-airflow-checked-out-in-airflow-home
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When airflow is checked out in the same directory as AIRFLOW_HOME, cleanup might remove everythig including .git folder. And this might happen because people might check out airflow in their HOME directory - and default AIRFLOW_HOME is ${HOME}/airflow.
THis PR will detect if Airflow is checked out AIRFLOW_HOME and will error out in this case.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.