Move operator color back to a badge vs node background#37945
Closed
bbovenzi wants to merge 1 commit intoapache:mainfrom
Closed
Move operator color back to a badge vs node background#37945bbovenzi wants to merge 1 commit intoapache:mainfrom
bbovenzi wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
I wonder if we could tweak the color for skipped. If it doesn’t stick out this much in a DAG, I’d suggest using that as the background color like in the thumbnailㄡ |
Contributor
Author
Member
|
Where is the operator color in your last screenshot? |
Contributor
Author
Its still around the operator name. |
Member
|
I see it now, yep, lgtm. |
9955dcb to
19800c2
Compare
Member
|
I like this |
Contributor
Author
|
Closing in favor of #38084 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some operator colors are too similar to task state colors leading to confusion. Moving it back to just the operator badge. Also fixed a bug with the border color not showing up for some task states
Also, I'm open to feedback on if we should mix what the border of a task means in the graph vs the minimap. In the graph its the state, in the minimap its the selection.
Before. See how

run_this_lastmight look like it was successfulAfter:

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.