Skip to content

Move operator color back to a badge vs node background#37945

Closed
bbovenzi wants to merge 1 commit intoapache:mainfrom
astronomer:restore-operator-badge-color
Closed

Move operator color back to a badge vs node background#37945
bbovenzi wants to merge 1 commit intoapache:mainfrom
astronomer:restore-operator-badge-color

Conversation

@bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Mar 6, 2024

Some operator colors are too similar to task state colors leading to confusion. Moving it back to just the operator badge. Also fixed a bug with the border color not showing up for some task states

Also, I'm open to feedback on if we should mix what the border of a task means in the graph vs the minimap. In the graph its the state, in the minimap its the selection.

Before. See how run_this_last might look like it was successful
Screenshot 2024-03-06 at 2 49 52 PM

After:
Screenshot 2024-03-06 at 12 52 28 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.8.3 milestone Mar 6, 2024
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 6, 2024
@uranusjr
Copy link
Member

uranusjr commented Mar 7, 2024

I wonder if we could tweak the color for skipped. If it doesn’t stick out this much in a DAG, I’d suggest using that as the background color like in the thumbnailㄡ

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Mar 7, 2024

Something like this?

Screenshot 2024-03-07 at 3 40 43 PM

@jedcunningham
Copy link
Member

Where is the operator color in your last screenshot?

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Mar 7, 2024

Where is the operator color in your last screenshot?

Its still around the operator name.

@jedcunningham
Copy link
Member

I see it now, yep, lgtm.

@bbovenzi bbovenzi force-pushed the restore-operator-badge-color branch from 9955dcb to 19800c2 Compare March 12, 2024 17:26
@uranusjr
Copy link
Member

I like this

@bbovenzi
Copy link
Contributor Author

Closing in favor of #38084

@bbovenzi bbovenzi closed this Mar 12, 2024
@jedcunningham jedcunningham deleted the restore-operator-badge-color branch March 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants