Skip to content

Add the possibility of custom probes in flower helm deployment#38069

Closed
Paul-Michaud wants to merge 1 commit intoapache:mainfrom
Paul-Michaud:main
Closed

Add the possibility of custom probes in flower helm deployment#38069
Paul-Michaud wants to merge 1 commit intoapache:mainfrom
Paul-Michaud:main

Conversation

@Paul-Michaud
Copy link

This PR adds the possibility to configure custom probes for the flower deployment in the airflow helm chart. It also add the possibility to fully disable probes.

I would like to be able to use httpGet probe rather than the exec one configured at the moment, I figured out that it would be simpler to be able to fully customize the probe rather that to add many variables.

Example of the probe I would like to use

    readinessProbe:                  
      failureThreshold: 10
      httpGet:                                
        path: /flower/
        port: 5555                     
        scheme: HTTP   
      initialDelaySeconds: 10                 
      periodSeconds: 5
      successThreshold: 1
      timeoutSeconds: 1

I want a probe like this because I use FLOWER_URL_PREFIX=/flower and I need the probe to be able to query the right path.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 12, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 27, 2024
@github-actions github-actions bot closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant