-
Notifications
You must be signed in to change notification settings - Fork 16.2k
Fix SparkKubernetesOperator when using initContainers #38119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you add unit test to avoid regression? |
Sure, will do |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, add a few tests
|
@ShelRoman kind reminder, can you please add tests to cover this change? |
done |
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me +1
@eladkal @hussein-awala WDYT?
I found this error while trying to use
initContainerswith spark job after upgradingapache-airflow-providers-cncf-kubernetesto8.0.1(reproducible on8.0.0as well).Using a patched operator with these changes helped to overcome the issue.
There might be other statutes to be included in this check.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.