Conversation
Taragolis
added
the
full tests needed
boring-cyborg
bot
added
the
area:production-image
Taragolis
force-pushed
the
modify-docker-tests
branch
from
a36fb6e to
37f7922
Compare
Member
|
Nice refactor and python_on_whales - I remember we discussed it in #34254 (comment) -> I think it's a good one to use it now for those docker tests. |
potiuk
approved these changes
Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempt to reduce number of subprocess usage and switch to
python-on-whaleswhere it possible.The main benefit that we do not need to parse output manually instead of we could work directly with objects (Spoiler Alert: Under the hood
python-on-whalesdo that). In addition debugging become more easier, because you might inspect objects retrieved frompython-on-whales.There is no any speedup on tests expected, maybe even increase a bit but I guess it shouldn't be noticeable.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.