Use relative-imports (TID252) instead of pygrep rule#38428
Merged
potiuk merged 1 commit intoapache:mainfrom Mar 24, 2024
Merged
Use relative-imports (TID252) instead of pygrep rule#38428potiuk merged 1 commit intoapache:mainfrom
relative-imports (TID252) instead of pygrep rule#38428potiuk merged 1 commit intoapache:mainfrom
Conversation
Taragolis
requested review from
ashb,
eladkal,
jedcunningham,
o-nikolas and
potiuk
as code owners
boring-cyborg
bot
added
area:dev-tools
area:logging
area:providers
kind:documentation
provider:amazon
Taragolis
added
the
changelog:skip
Taragolis
force-pushed
the
no-relative-inport-ruff
branch
from
6636c9e to
16069b3
Compare
potiuk
approved these changes
Mar 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace one on our pre-commit hook by included into the ruff rule https://docs.astral.sh/ruff/rules/relative-imports/
This one is unsafe fixable, however I made all changes by
ruff check --unsafe-fixes --fixMaybe we want to exclude specific module/directory from this check, at that moment pygrep rule allow relative imports into the
docsandtestsbut not inkubernetes_tests,helm_tests,docker_tests^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.