Skip to content

[AIRFLOW-3007] Update backfill example in Scheduler docs#3847

Merged
r39132 merged 1 commit intoapache:masterfrom
kaxil:scheduler_doc_change
Sep 4, 2018
Merged

[AIRFLOW-3007] Update backfill example in Scheduler docs#3847
r39132 merged 1 commit intoapache:masterfrom
kaxil:scheduler_doc_change

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Sep 4, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

image

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

The scheduler docs at https://airflow.apache.org/scheduler.html#backfill-and-catchup use deprecated way of passing `schedule_interval`. `schedule_interval` should be pass to DAG as a separate parameter and not as a default arg.
@r39132
Copy link
Contributor

r39132 commented Sep 4, 2018

Good catch! +1

@r39132 r39132 merged commit 93c6a50 into apache:master Sep 4, 2018
@kaxil kaxil deleted the scheduler_doc_change branch January 8, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants