Do not use cache to install breeze#38491
Merged
Merged
Conversation
Using cache for breeze might cause various issues and it does not really speed up the installation that significantly (installing breeze is about 20 seconds and restoring cache and checking if breeze is installed there is ~8 seconds, so we are savig some 10 seconds per build. Removing cache will make breeze always runs in a clean state and also it has less potential for potential cache-poisoning issues. Since cache is shared among multiple workflows and runs, that is also far safer option from security point of view.
potiuk
requested review from
Taragolis,
amoghrajesh,
eladkal,
hussein-awala and
jedcunningham
eladkal
approved these changes
Mar 26, 2024
amoghrajesh
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using cache for breeze might cause various issues and it does not really speed up the installation that significantly (installing breeze is about 20 seconds and restoring cache and checking if breeze is installed there is ~8 seconds, so we are savig some 10 seconds per build.
Removing cache will make breeze always runs in a clean state and also it has less potential for potential cache-poisoning issues. Since cache is shared among multiple workflows and runs, that is also far safer option from security point of view.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.