Respect @pytest.mark.filterwarnings in prohibited warnings#38684
Merged
Taragolis merged 2 commits intoapache:mainfrom Apr 4, 2024
Merged
Respect @pytest.mark.filterwarnings in prohibited warnings#38684Taragolis merged 2 commits intoapache:mainfrom
@pytest.mark.filterwarnings in prohibited warnings#38684Taragolis merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
An unpleasant side effect: now it also affects warnings in fixtures, e.g. DagBag which collect example DAGs skip all DAGs which contain deprecated stuff, e.g. SubDagOperator. Need to find better way to import it, for now import it with temporary suppress warnings. |
uranusjr
approved these changes
Apr 3, 2024
Contributor
Author
|
One more rebase before merge |
95c9c85 to
6b1c3fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this issue when tried to resolve some warnings in tests, in current implementation we add error filter before start the test but when
@pytest.mark.filterwarningsalready add filter into thewarning.filtersin this case this code still raise an errorThe solution pretty simple add appropriate markers during the tests collection, when test item just collected, and add it before all explicitly set markers. in this case the order of marker execution would be same as this code
which turned into the this order into the
warning.filtersI've check this behaviour in both pytest 7.4 and pytest 8.1+
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.