Drop pre-release specification from pre-installed provider versions#38703
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 3, 2024
Conversation
When Airflow installs a pre-release provider version we can add the `>=x.y.zdev0` or `>=x.y.zrc1` to pre-release provider specification. This is necessary to install dev0 or rc* packages when we release them for testing, when the pre-installed provider is a "chicken-egg" provider that does not yet have an "official" version - because otherwise the dependency would not allow the provider to be installed. However, the "final" package should have just `>=x.y.z` without the pre-release specification, because by the time we release the final version, the pre-release provider package should be already released. This PR implements such pre-release stripping. In cse we prepare the "final" version of the airflow package, all the preinstalled provider's specifications got the `>=version` stripped off all the prerelease information. The `>=1.2.0dev0` or `>=1.2.0rc1` is for example turned into `>=`1.2.0`.
potiuk
requested review from
Taragolis,
eladkal,
ephraimbuddy,
ferruzzi,
jedcunningham and
pankajkoti
eladkal
approved these changes
Apr 3, 2024
Member
Author
|
The failing 3.12 test fixed in #38704 |
potiuk
deleted the
remove-pre-release-provider-dependencies-from-preinstalled-providers-in-final-package
branch
potiuk
added a commit
that referenced
this pull request
Apr 3, 2024
…38703) When Airflow installs a pre-release provider version we can add the `>=x.y.zdev0` or `>=x.y.zrc1` to pre-release provider specification. This is necessary to install dev0 or rc* packages when we release them for testing, when the pre-installed provider is a "chicken-egg" provider that does not yet have an "official" version - because otherwise the dependency would not allow the provider to be installed. However, the "final" package should have just `>=x.y.z` without the pre-release specification, because by the time we release the final version, the pre-release provider package should be already released. This PR implements such pre-release stripping. In cse we prepare the "final" version of the airflow package, all the preinstalled provider's specifications got the `>=version` stripped off all the prerelease information. The `>=1.2.0dev0` or `>=1.2.0rc1` is for example turned into `>=`1.2.0`. Co-authored-by: Andrey Anshin <Andrey.Anshin@taragol.is> (cherry picked from commit 1759336)
potiuk
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Airflow installs a pre-release provider version we can add the
>=x.y.zdev0or>=x.y.zrc1to pre-release provider specification.This is necessary to install dev0 or rc* packages when we release them for testing, when the pre-installed provider is a "chicken-egg" provider that does not yet have an "official" version - because otherwise the dependency would not allow the provider to be installed.
However, the "final" package should have just
>=x.y.zwithout the pre-release specification, because by the time we release the final version, the pre-release provider package should be already released.This PR implements such pre-release stripping. In cse we prepare the "final" version of the airflow package, all the preinstalled provider's specifications got the
>=versionstripped off all the prerelease information. The>=1.2.0dev0or>=1.2.0rc1is for example turned into>=1.2.0.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.