Rename UV_REQUEST_TIMEOUT to UV_HTTP_TIMEOUT and make it more usable#38739
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 4, 2024
Merged
Rename UV_REQUEST_TIMEOUT to UV_HTTP_TIMEOUT and make it more usable#38739potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:dev-tools
area:production-image
potiuk
requested review from
Taragolis,
amoghrajesh,
eladkal,
jscheffl and
uranusjr
The UV_REQUEST_TIMEOUT was only briefly the correct parameter name, (UV 1.6.0). It is still working as a fallback, but the right parameter name is UV_HTTP_TIMEOUT. This PR renames the flag and build args/env variables appropriately - and also fixes a few annoyances connected with this parameter: * it was not possible to specify --use-uv/uv-timout for `breeze` `breeze shell` and `breeze start-airflow` commands which could resut in rebuilding the image and you had to rebuild image manually with `ci-image build` if you wanted to change uv/no-uv * the ARG was not properly passed in PROD image and resulted in empty string set as UV_REQUEST_TIMEOUT which resulted with a warning printed by UV and falling back to default 300 * we have now global constant for default timeout
potiuk
force-pushed
the
improve-uv-timeout-setting
branch
from
099cd21 to
1d7e41b
Compare
hussein-awala
approved these changes
Apr 4, 2024
amoghrajesh
approved these changes
Apr 4, 2024
eladkal
approved these changes
Apr 4, 2024
Member
Author
|
Images built. breeze checks passed. Looks good to merge. |
potiuk
added a commit
that referenced
this pull request
Apr 4, 2024
…38739) The UV_REQUEST_TIMEOUT was only briefly the correct parameter name, (UV 1.6.0). It is still working as a fallback, but the right parameter name is UV_HTTP_TIMEOUT. This PR renames the flag and build args/env variables appropriately - and also fixes a few annoyances connected with this parameter: * it was not possible to specify --use-uv/uv-timout for `breeze` `breeze shell` and `breeze start-airflow` commands which could resut in rebuilding the image and you had to rebuild image manually with `ci-image build` if you wanted to change uv/no-uv * the ARG was not properly passed in PROD image and resulted in empty string set as UV_REQUEST_TIMEOUT which resulted with a warning printed by UV and falling back to default 300 * we have now global constant for default timeout (cherry picked from commit 329c76d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UV_REQUEST_TIMEOUT was only briefly the correct parameter name, (UV 1.6.0). It is still working as a fallback, but the right parameter name is UV_HTTP_TIMEOUT. This PR renames the flag and build args/env variables appropriately - and also fixes a few annoyances connected with this parameter:
it was not possible to specify --use-uv/uv-timout for
breezebreeze shellandbreeze start-airflowcommands which could resut in rebuilding the image and you had to rebuild image manually withci-image buildif you wanted to change uv/no-uvthe ARG was not properly passed in PROD image and resulted in empty string set as UV_REQUEST_TIMEOUT which resulted with a warning printed by UV and falling back to default 300
we have now global constant for default timeout
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.