Skip to content

[AIRFLOW-3034]: Readme updates : Add Slack & Twitter, remove Gitter #3878

Merged
r39132 merged 1 commit intoapache:masterfrom
r39132:update_readme_with_slack_link
Sep 13, 2018
Merged

[AIRFLOW-3034]: Readme updates : Add Slack & Twitter, remove Gitter #3878
r39132 merged 1 commit intoapache:masterfrom
r39132:update_readme_with_slack_link

Conversation

@r39132
Copy link
Contributor

@r39132 r39132 commented Sep 10, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    N/A.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

codecov-io commented Sep 10, 2018

Codecov Report

Merging #3878 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         200      200           
  Lines       15889    15889           
=======================================
  Hits        12313    12313           
  Misses       3576     3576

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b041587...96f6d84. Read the comment docs.

@r39132 r39132 requested review from ashb, feng-tao and kaxil September 10, 2018 23:48
@feng-tao
Copy link
Member

hey @r39132 , there are some -1 on the vote thread you started. Have we decided the final decision of retiring gitter? If that's the case, the pr lgtm.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @r39132 We might need to have a heruko app or something similar for users to join the Slack Workspace otherwise new users won't be able to join without invitation.

An app like https://github.com/outsideris/slack-invite-automation

@r39132 r39132 force-pushed the update_readme_with_slack_link branch from e88abc1 to 6b15de8 Compare September 11, 2018 16:23
@r39132
Copy link
Contributor Author

r39132 commented Sep 11, 2018

Hi @feng-tao This PR doesn't retire Gitter, if that is even possible. It just removes it from the Readme. To retire it, we may need Infra support and possibly a second vote. Currently, the slack adoption is 5-10x that of Gitter (~120 folks on Slack).

@kaxil That's a good point. Want to take a stab at it?

@feng-tao
Copy link
Member

feng-tao commented Sep 11, 2018

lgtm, thanks @r39132 for the info.

@kaxil
Copy link
Member

kaxil commented Sep 11, 2018

@r39132 : I have deployed the app on Heroku: https://apache-airflow-slack.herokuapp.com/

Can you add this in the Readme? Can you also announce this on mailing-list / twitter?

@r39132 r39132 force-pushed the update_readme_with_slack_link branch from 6b15de8 to e7c69a7 Compare September 12, 2018 04:22
Copy link
Contributor

@tedmiston tedmiston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r39132 Glad to see this PR. I was about to send something similar. Overall I'm in favor.

Given the mailing list response with some resistance to Slack, what if we kept the Gitter link (but not badge) in the readme but marked it as Chat (alternative) or (legacy) or something?

Perhaps it's progress towards being all in on Slack. But there is still some useful info in the Gitter so I can appreciate having the link around for archival purposes.

@r39132 r39132 force-pushed the update_readme_with_slack_link branch 2 times, most recently from 6861c16 to c28f493 Compare September 12, 2018 17:10
@r39132
Copy link
Contributor Author

r39132 commented Sep 12, 2018

@tedmiston What plan would you recommend for transitioning off Gitter? I can't imagine it would be a good idea to maintain 2 places? Less than one week after creating the slack channel, we have 170+ folks on slack and maybe 10-15 peoples on Gitter.

Also, this change does not remove gitter.. it just tells newbies to use Slack...existing users of Gitter can continue.

@r39132 r39132 changed the title [AIRFLOW-3034]: Update Readme : Add slack link, remove Gitter [AIRFLOW-3034]: Readme updates : Add Slack & Twitter, remove Gitter Sep 12, 2018
@r39132 r39132 force-pushed the update_readme_with_slack_link branch from c28f493 to 9087014 Compare September 12, 2018 22:24
@r39132 r39132 force-pushed the update_readme_with_slack_link branch from 9087014 to 96f6d84 Compare September 12, 2018 22:46
@r39132 r39132 merged commit a79b92a into apache:master Sep 13, 2018
@r39132 r39132 deleted the update_readme_with_slack_link branch September 13, 2018 05:36
@ashb
Copy link
Member

ashb commented Sep 13, 2018

Where did you get the 10-15 people on Gitter btw?

screen shot 2018-09-13 at 10 39 16

(I don't know if that is active people, or just people who have ever signed in to Gitter, but Gitter says 2837 people in the airflow channel. There aren't that many active people, certainly)

@r39132
Copy link
Contributor Author

r39132 commented Sep 13, 2018

@ashb 3k might be the total. What are the weekly actives? We can keep both channels as long as it makes sense, though I’m always wary of prolonged Roman-riding.

@ashb
Copy link
Member

ashb commented Sep 13, 2018

Volume is definately dropping off in Gitter (and I'm encouraging/mentioning the slack channel) - I'll stick around in Gitter until it's quiet

@tedmiston
Copy link
Contributor

I don't have a specific recommendation for transitioning off Gitter as I'm not very active on Gitter personally. I like @ashb's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants