Activate RUF006 rule to detect dangling asyncio tasks#38947
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 12, 2024
Merged
Activate RUF006 rule to detect dangling asyncio tasks#38947potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:google
Taragolis
approved these changes
Apr 11, 2024
Contributor
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
Nice. Small NIT, maybe you could move this rule definition before RUF100 rule.
dirrao
approved these changes
Apr 12, 2024
uranusjr
approved these changes
Apr 12, 2024
potiuk
approved these changes
Apr 12, 2024
utkarsharma2
added
type:misc/internal
utkarsharma2
pushed a commit
that referenced
this pull request
Jun 4, 2024
(cherry picked from commit b3b9079)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit b3b9079)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is useful to detect the asyncio tasks which are created without setting their reference to a variable because this could lead to unexpected results like removing them by GC.