Skip to content

PYODBC MSSQL HOOK WORKS with Azure SQL DB#3896

Closed
gautamsumeet wants to merge 1 commit intoapache:masterfrom
gautamsumeet:master
Closed

PYODBC MSSQL HOOK WORKS with Azure SQL DB#3896
gautamsumeet wants to merge 1 commit intoapache:masterfrom
gautamsumeet:master

Conversation

@gautamsumeet
Copy link

When there was a large insert to MSSQL Azure Database, the insert always timedout, but when tested with PYODBC hook it worked without any problem. thats why i created this hook so that it would be helpful to people who has problems like me.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

When there was a large insert to MSSQL Azure Database, the insert always timedout, but when tested with PYODBC hook it worked without any problem. thats why i created this hook so that it would be helpful to people who has problems like me.
@r39132
Copy link
Contributor

r39132 commented Sep 13, 2018

@gautamsumeet please add tests. Also, you must follow commit guidelines (e.g. create a Jira, prepend [AIRFLOW-XXXX] in your commit to tie the commit to the JIRA, do the same with your PR, etc...)

@bolkedebruin @Fokko @ashb @kaxil How do we decide whether a hook belongs here or under contrib/hooks?

@r39132
Copy link
Contributor

r39132 commented Sep 17, 2018

@gautamsumeet Please reopen when meeting contribution guidelines.

@r39132 r39132 closed this Sep 17, 2018
@feng-tao
Copy link
Member

I think the code lack testing, and side qq: do we want to have more hooks / operators under contrib folder BTW? How do we know whether it works or not or how well does it get maintained?

@richardkippers
Copy link

This would be helpful for me since Azure SQL is performing slow when inserting large amounts of data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants