Adds job_id as path param in update permission #38962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
reviewed
Apr 12, 2024
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
LGTM. @SubhamSinghal Were we able to test this with the operator in a DAG that this updates the job's permission well now?
Contributor
Author
|
@pankajkoti not till now. I am trying to understand how to test this locally. |
Member
@SubhamSinghal Are you not using Breeze for local development? It makes life a lot easier for developing and testing. |
Lee-W
reviewed
Apr 12, 2024
Contributor
Author
|
Tested. Code is working fine. |
dirrao
approved these changes
Apr 14, 2024
pankajkoti
reviewed
Apr 14, 2024
12 tasks
pankajkoti
reviewed
Apr 14, 2024
pankajkoti
approved these changes
Apr 14, 2024
pankajkoti
force-pushed
the
bugfix/add-path-param-to-update-permission
branch
from
24479b3 to
331dff8
Compare
Lee-W
approved these changes
Apr 14, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job_id needs to be passed as path param in update job permission api.
api link: https://docs.databricks.com/api/workspace/jobs/updatepermissions