Skip to content

Move prohibited warnings detection in deferrable pytest plugin#39411

Merged
potiuk merged 1 commit intoapache:mainfrom
Taragolis:prohibitted-warning-plugin
May 10, 2024
Merged

Move prohibited warnings detection in deferrable pytest plugin#39411
potiuk merged 1 commit intoapache:mainfrom
Taragolis:prohibitted-warning-plugin

Conversation

@Taragolis
Copy link
Contributor

@Taragolis Taragolis commented May 5, 2024

related: #38642

Move all logic around existed functionality into the separate plugin, which allow to do additional things without turned root conftest.py into the mess

  • Allow to disable detect prohibited warnings locally: --disable-forbidden-warnings or set warnings to ignore -W "ignore"
  • Move list of prohibited warnings into the pyproject.toml
  • Analyse test failure and if it due to listed prohibited warning show hint to the developer

image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis Taragolis added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge labels May 5, 2024
@jscheffl jscheffl removed their request for review May 5, 2024 07:53
@jscheffl
Copy link
Contributor

jscheffl commented May 5, 2024

I'm taking myself off the reviewer list as I have no clue about what this plugin is about and hope others do :-D

@Taragolis Taragolis force-pushed the prohibitted-warning-plugin branch from a4b86ed to f37609b Compare May 8, 2024 12:00
@Taragolis Taragolis force-pushed the prohibitted-warning-plugin branch from f37609b to 1d81080 Compare May 10, 2024 07:52
@potiuk potiuk merged commit 64277cf into apache:main May 10, 2024
@Taragolis Taragolis deleted the prohibitted-warning-plugin branch May 10, 2024 09:10
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants