Skip to content

FIX: do not reattach to finished pod on restart of k8s pod operator#39414

Closed
NotYuki wants to merge 1 commit intoapache:mainfrom
NotYuki:fix/k8s-reattach-on-restart
Closed

FIX: do not reattach to finished pod on restart of k8s pod operator#39414
NotYuki wants to merge 1 commit intoapache:mainfrom
NotYuki:fix/k8s-reattach-on-restart

Conversation

@NotYuki
Copy link

@NotYuki NotYuki commented May 5, 2024

For now, if KubernetesPodOperator.reattach_on_restart is enabled, the Operator tries to find a pod regardless of its status. This might lead to an unhealthy deadlock situation if on_finish_action is set to KEEP_POD or DELETE_SUCCEEDED_POD.

For instance, if a task has on_finish_action = OnFinishAction.DELETE_SUCCEEDED_POD and it fails on the first run, any subsequent attempts of the same task will fail immediately with a Kubernetes API error, as Airflow will try to attach to a finished pod.

This PR introduces changes to KPO, allowing it to reattach only to running pods.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels May 5, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented May 5, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotYuki NotYuki marked this pull request as draft May 5, 2024 12:27
@NotYuki
Copy link
Author

NotYuki commented May 5, 2024

Thanks for the comment. Actually, after delving deeper into the Kubernetes tests and KPO code, I've noticed similar logic already implemented with patch_already_checked() method. I want to spend some time investigating why it doesn't work as expected on my k8s environment.

if not namespace:
raise ValueError("Pod namespace is empty")
pod = self.find_pod(namespace, context=context)
if pod and pod.status and pod.status.phase == "Running":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the next retry attempt comes back, by that time the task might move from running to completed state. Why do you want to rerun the same?

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jun 21, 2024
@github-actions github-actions bot closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants