Skip to content

Add pre-commit to correct mismatching revision IDs in migration file#39480

Merged
ephraimbuddy merged 2 commits intoapache:mainfrom
astronomer:correct-mismatching-revision-nums
May 8, 2024
Merged

Add pre-commit to correct mismatching revision IDs in migration file#39480
ephraimbuddy merged 2 commits intoapache:mainfrom
astronomer:correct-mismatching-revision-nums

Conversation

@ephraimbuddy
Copy link
Contributor

Using revision = ID and down_revision = ID as the base, correct the Revision ID: ID and Revises: ID text in migration files. It's easy to forget to update these IDs when we change the down_revision or revision IDs. This will keep it in check.

@ephraimbuddy ephraimbuddy requested review from ashb and potiuk as code owners May 8, 2024 10:06
@boring-cyborg boring-cyborg bot added area:db-migrations PRs with DB migration area:dev-tools labels May 8, 2024
Using `revision = ID` and `down_revision = ID` as the base, correct the `Revision ID: ID`
and `Revises: ID` text in migration files. It's easy to forget to update these IDs
when we change the down_revision or revision IDs. This will keep it in check.
@ephraimbuddy ephraimbuddy force-pushed the correct-mismatching-revision-nums branch from de7ea9f to 731c31c Compare May 8, 2024 11:28
@ephraimbuddy ephraimbuddy merged commit e794d6c into apache:main May 8, 2024
@ephraimbuddy ephraimbuddy deleted the correct-mismatching-revision-nums branch May 8, 2024 18:16
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
…pache#39480)

* Add pre-commit to correct mismatching revision IDs in migration file

Using `revision = ID` and `down_revision = ID` as the base, correct the `Revision ID: ID`
and `Revises: ID` text in migration files. It's easy to forget to update these IDs
when we change the down_revision or revision IDs. This will keep it in check.

* fixup! Add pre-commit to correct mismatching revision IDs in migration file
@utkarsharma2 utkarsharma2 added type:new-feature Changelog: New Features type:misc/internal Changelog: Misc changes that should appear in change log and removed type:new-feature Changelog: New Features labels Jun 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 4, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…pache#39480)

* Add pre-commit to correct mismatching revision IDs in migration file

Using `revision = ID` and `down_revision = ID` as the base, correct the `Revision ID: ID`
and `Revises: ID` text in migration files. It's easy to forget to update these IDs
when we change the down_revision or revision IDs. This will keep it in check.

* fixup! Add pre-commit to correct mismatching revision IDs in migration file
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:misc/internal Changelog: Misc changes that should appear in change log labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:db-migrations PRs with DB migration area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants