Skip to content

Add missing test for json api client#39870

Merged
potiuk merged 7 commits intoapache:mainfrom
yangyulely:main
May 28, 2024
Merged

Add missing test for json api client#39870
potiuk merged 7 commits intoapache:mainfrom
yangyulely:main

Conversation

@yangyulely
Copy link
Contributor

@yangyulely yangyulely commented May 27, 2024

This commit adds missing test for json api client to improve the coverage.
Test result looks fine:
image
related: #35127

@boring-cyborg
Copy link

boring-cyborg bot commented May 27, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirrao dirrao requested a review from potiuk May 27, 2024 14:39
@potiuk
Copy link
Member

potiuk commented May 27, 2024

This API is experimental/deprecated - but yeah if the tests workmight be a good idea.

@potiuk potiuk merged commit 130e9df into apache:main May 28, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented May 28, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
* delete unused variables

* unchange test file

* Add missing test for json api client

* fix static check

* fix static check

* fix status check
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* delete unused variables

* unchange test file

* Add missing test for json api client

* fix static check

* fix static check

* fix status check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants