Increase Health Check parameters for mssql integration#39877
Increase Health Check parameters for mssql integration#39877potiuk merged 1 commit intoapache:mainfrom
Conversation
The values for mssql integration were too low, particularly the timeout of 3s was far too low. Per documentation: https://github.com/docker/cli/blob/5bf86c198488c7f78f2ffd05a8a2441f719d3b98/docs/reference/builder.md#healthcheck Increasing the values shoudl bring stability back.
|
CC: @shahar1 |
|
Currently it randomly fails - for example https://github.com/apache/airflow/actions/runs/9256599429/job/25463195510?pr=39851 |
|
BTW. Those values are pure guesses :), so it might not help either (but they are high enough it should if this is really a problem with slow startup time for mssql |
|
Thanks! Some related reading materials that I found: |
|
https://github.com/apache/airflow/actions/runs/9256982108/job/25464448138 It's still not happy. Maybe we could copy from this script (taken from Stack Overflow's link above) as the health check entry point? |
|
Next attempt - let's see. In the logs you can enable showing timestamp and I saw a few successful tests where it took ~18 s for the mssql container to start - dangerously close to 20s we had. |
The values for mssql integration were too low, particularly the timeout of 3s was far too low. Per documentation: https://github.com/docker/cli/blob/5bf86c198488c7f78f2ffd05a8a2441f719d3b98/docs/reference/builder.md#healthcheck Increasing the values shoudl bring stability back.
The values for mssql integration were too low, particularly the timeout of 3s was far too low. Per documentation: https://github.com/docker/cli/blob/5bf86c198488c7f78f2ffd05a8a2441f719d3b98/docs/reference/builder.md#healthcheck Increasing the values shoudl bring stability back.
The values for mssql integration were too low, particularly the timeout of 3s was far too low. Per documentation:
https://github.com/docker/cli/blob/5bf86c198488c7f78f2ffd05a8a2441f719d3b98/docs/reference/builder.md#healthcheck
Increasing the values shoudl bring stability back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.