Skip to content

Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update#39879

Closed
dirrao wants to merge 3 commits intoapache:mainfrom
dirrao:update_chart_postgres_airflow_version
Closed

Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update#39879
dirrao wants to merge 3 commits intoapache:mainfrom
dirrao:update_chart_postgres_airflow_version

Conversation

@dirrao
Copy link
Contributor

@dirrao dirrao commented May 27, 2024

Chart Postgres:16.3.0 and airflow default version description: 2.9.1 update

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label May 27, 2024
@potiuk potiuk changed the title Chart Postgres:16.3.0 and airflow default version description: 2.9.1 update Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update May 28, 2024
@potiuk
Copy link
Member

potiuk commented May 28, 2024

I am not sure we want to change Postgres version "like that" without more serious testing and consideration and likely resulting in a significant note.

There are certain consequences of changing Postgres version. In the past we had the case where changing Postgres version - see https://github.com/apache/airflow/blob/main/chart/RELEASE_NOTES.rst#airflow-helm-chart-1120-2024-02-11

It would be great if testing of the scenario is performed and in case (which I believe it will be happening again) manual migration is neded we need to mention that in in a significant newsfragment - so that it lands in the relase notes: (https://github.com/apache/airflow/tree/main/chart/newsfragments)

While using embedded Postgres is not recommended for "production" - we know a number of our users actually rely on it for various purposes - including development and testing, and while we do not aim to keep automated migration and backwards-compatibility, some way of warning them is necessary in case the migration requires some manual step.

@dirrao
Copy link
Contributor Author

dirrao commented May 28, 2024

I am not sure we want to change Postgres version "like that" without more serious testing and consideration and likely resulting in a significant note.

There are certain consequences of changing Postgres version. In the past we had the case where changing Postgres version - see https://github.com/apache/airflow/blob/main/chart/RELEASE_NOTES.rst#airflow-helm-chart-1120-2024-02-11

It would be great if testing of the scenario is performed and in case (which I believe it will be happening again) manual migration is neded we need to mention that in in a significant newsfragment - so that it lands in the relase notes: (https://github.com/apache/airflow/tree/main/chart/newsfragments)

While using embedded Postgres is not recommended for "production" - we know a number of our users actually rely on it for various purposes - including development and testing, and while we do not aim to keep automated migration and backwards-compatibility, some way of warning them is necessary in case the migration requires some manual step.

Thanks. We have been using the Postgres 16. we haven't faced any issues during the upgrade from 13 to 16. However, we are using external Postgres. I will test it and update the documentation.

Comment on lines -79 to +83
- description: 'Misc: Default airflow version to 2.8.3'
- description: 'Misc: Default airflow version to 2.9.1'
kind: changed
links:
- name: '#38036'
url: https://github.com/apache/airflow/pull/38036
- name: '#39433'
url: https://github.com/apache/airflow/pull/39433
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done during the next release anyways, that's why it isn't done in those Airflow version bump PRs.

Said another way, this is just a different representation of the changelog for chart version 1.13.0.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 21, 2024
@github-actions github-actions bot closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants