Skip to content

Remove dependency on special tests for tests finalization#40264

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:remove-dependency-on-special-tests-for-finalization
Jun 15, 2024
Merged

Remove dependency on special tests for tests finalization#40264
potiuk merged 1 commit intoapache:mainfrom
potiuk:remove-dependency-on-special-tests-for-finalization

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Jun 15, 2024

Tests finalization is run generally when all tests succeded in canary run. What the finalization does is:

  • updating constrainst
  • pushing them
  • updating image cache
  • summarizing warnings

However special tests are really to test some special cases - back compatibility, lowest dependencies, latest boto etc. All those tests will only be run in a few selected PRs where we upgrade dependencies and they will not affect "regular" PRs, so we can safely update the constraints and update the cache without waiting for special tests.

This will increase the frequency of updates to constraints - because now they might be quite delayed in case some special tests fail, but this is unnecessary holding the constraints update.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Tests finalization is run generally when all tests succeded in
canary run. What the finalization does is:

* updating constrainst
* pushing them
* updating image cache
* summarizing warnings

However special tests are really to test some special cases - back
compatibility, lowest dependencies, latest boto etc. All those tests
will only be run in a few selected PRs where we upgrade dependencies
and they will not affect "regular" PRs, so we can safely update
the constraints and update the cache without waiting for special tests.

This will increase the frequency of updates to constraints - because
now they might be quite delayed in case some special tests fail, but
this is unnecessary holding the constraints update.
@potiuk
Copy link
Copy Markdown
Member Author

potiuk commented Jun 15, 2024

This should help with much more frequent refresh of constraints and update - they were impacted by stability of special tests so far, but this was not really necesary.

@potiuk potiuk merged commit 1d7ede7 into apache:main Jun 15, 2024
@potiuk potiuk deleted the remove-dependency-on-special-tests-for-finalization branch June 15, 2024 17:27
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Tests finalization is run generally when all tests succeded in
canary run. What the finalization does is:

* updating constrainst
* pushing them
* updating image cache
* summarizing warnings

However special tests are really to test some special cases - back
compatibility, lowest dependencies, latest boto etc. All those tests
will only be run in a few selected PRs where we upgrade dependencies
and they will not affect "regular" PRs, so we can safely update
the constraints and update the cache without waiting for special tests.

This will increase the frequency of updates to constraints - because
now they might be quite delayed in case some special tests fail, but
this is unnecessary holding the constraints update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants