Optimize startup time for parallel tests#40388
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 23, 2024
Merged
Conversation
amoghrajesh
approved these changes
Jun 23, 2024
potiuk
force-pushed
the
pull-images-before-running-parallel-tests
branch
from
64360a6 to
3943826
Compare
potiuk
commented
Jun 23, 2024
hussein-awala
approved these changes
Jun 23, 2024
Member
Author
|
There were some strange output on "lowest direct" tests in this one, so I will have to take a closer look before we merge this one :). |
When parallell tests start on CI, they are running parallel docker compose's and on a clean machine in CI this means that every parallel test is pulling the images needed to run tests. This means that backend images are pulled in parallell by all starting parallel runs. This PR optimizes this step - before running the tests in parallel we run `docker compose pull` once with the same compose files as tests - this will pull the necessary images only once. It should save a few seconds and save a lot of unnecessary traffic for CI tests - where same image is pulled multiple times - especially for self-hosted runners of ours where we run 8 docker compose instances in parallel.
potiuk
force-pushed
the
pull-images-before-running-parallel-tests
branch
from
3943826 to
6860f9d
Compare
Member
Author
Yeah. I had to disable caching of env variables - because they were always called without TEST_TYPE env variable. |
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
When parallell tests start on CI, they are running parallel docker compose's and on a clean machine in CI this means that every parallel test is pulling the images needed to run tests. This means that backend images are pulled in parallell by all starting parallel runs. This PR optimizes this step - before running the tests in parallel we run `docker compose pull` once with the same compose files as tests - this will pull the necessary images only once. It should save a few seconds and save a lot of unnecessary traffic for CI tests - where same image is pulled multiple times - especially for self-hosted runners of ours where we run 8 docker compose instances in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parallell tests start on CI, they are running parallel docker compose's and on a clean machine in CI this means that every parallel test is pulling the images needed to run tests. This means that backend images are pulled in parallell by all starting parallel runs.
This PR optimizes this step - before running the tests in parallel we run
docker compose pullonce with the same compose files as tests - this will pull the necessary images only once.It should save a few seconds and save a lot of unnecessary traffic for CI tests - where same image is pulled multiple times - especially for self-hosted runners of ours where we run 8 docker compose instances in parallel.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.