Skip to content

Conversation

@nevcohen
Copy link
Contributor

@nevcohen nevcohen commented Jul 12, 2024

Adding spark app id also to k8s cluster (like in yarn).
Useful for us for creating links to search the app in our spark history.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title Add spark kubernetes app id Add kubernetes_application_id to SparkSubmitHook Jul 12, 2024
@potiuk potiuk merged commit 469beef into apache:main Jul 14, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 14, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 23, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.10.0 milestone Jul 23, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@Aigul9
Copy link

Aigul9 commented Nov 26, 2025

@nevcohen hi! can you provide with some examples of usage? we're using our custom operator inherited from sparksubmitoperator, and i'm not sure how to get to the app_id in our case.

@nevcohen
Copy link
Contributor Author

We use this to create the url for spark history

@Aigul9
Copy link

Aigul9 commented Nov 26, 2025

@nevcohen yeah, we'd like too. could you give a snippet?

@nevcohen
Copy link
Contributor Author

We push this to the xcom, and then in the get_link we polling the xcom and generated the link

@Aigul9
Copy link

Aigul9 commented Nov 26, 2025

@nevcohen can you elaborate on the pushing mechanism? do you create SparkSubmitOperator? SparkSubmitHook? custom operator? is it in execute() or somewhere else? is it something like spark_app_id = operator._hook._kubernetes_application_id? but the value is none before creating pod and spark app, so in which method and how is it done?
please, provide with some example, your use case is exactly what we're trying to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:apache-spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants