-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add kubernetes_application_id to SparkSubmitHook
#40753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes_application_id to SparkSubmitHook
#40753
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
kubernetes_application_id to SparkSubmitHook
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
@nevcohen hi! can you provide with some examples of usage? we're using our custom operator inherited from sparksubmitoperator, and i'm not sure how to get to the app_id in our case. |
|
We use this to create the url for spark history |
|
@nevcohen yeah, we'd like too. could you give a snippet? |
|
We push this to the xcom, and then in the |
|
@nevcohen can you elaborate on the pushing mechanism? do you create SparkSubmitOperator? SparkSubmitHook? custom operator? is it in execute() or somewhere else? is it something like spark_app_id = operator._hook._kubernetes_application_id? but the value is none before creating pod and spark app, so in which method and how is it done? |
Adding spark app id also to k8s cluster (like in yarn).
Useful for us for creating links to search the app in our spark history.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.