Add pre-commit to check attrs of TI and TIHistory#40846
Merged
ephraimbuddy merged 6 commits intoapache:mainfrom Jul 19, 2024
Merged
Add pre-commit to check attrs of TI and TIHistory#40846ephraimbuddy merged 6 commits intoapache:mainfrom
ephraimbuddy merged 6 commits intoapache:mainfrom
Conversation
ephraimbuddy
requested review from
XD-DENG,
ashb,
jedcunningham,
kaxil and
potiuk
as code owners
potiuk
approved these changes
Jul 17, 2024
ephraimbuddy
force-pushed
the
add-precommit-tis
branch
from
0caf38c to
e2a4d48
Compare
ephraimbuddy
commented
Jul 18, 2024
eladkal
approved these changes
Jul 18, 2024
ephraimbuddy
force-pushed
the
add-precommit-tis
branch
2 times, most recently
from
9dee5da to
3711bc4
Compare
potiuk
approved these changes
Jul 18, 2024
ephraimbuddy
force-pushed
the
add-precommit-tis
branch
from
3711bc4 to
13e85c9
Compare
ephraimbuddy
force-pushed
the
add-precommit-tis
branch
from
7400140 to
3a9c977
Compare
ephraimbuddy
added
the
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Add pre-commit to check attrs of TI and TIHistory * fixup! Add pre-commit to check attrs of TI and TIHistory * fixup! fixup! Add pre-commit to check attrs of TI and TIHistory * Fix test * Add back try_number nullable false * Remove relationships
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was requested before, and I saw the value of this method of keeping the attributes in sync.