Skip to content

Bugfix/41067 Fix base_auth_manager #41105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Jul 29, 2024
Merged

Bugfix/41067 Fix base_auth_manager #41105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions tests/auth/managers/test_base_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from unittest.mock import MagicMock, Mock, patch

import pytest
from flask import Flask
from flask_appbuilder.menu import Menu

from airflow.auth.managers.base_auth_manager import BaseAuthManager, ResourceMethod
Expand All @@ -31,8 +30,6 @@
VariableDetails,
)
from airflow.exceptions import AirflowException
from airflow.www.extensions.init_appbuilder import init_appbuilder
from airflow.www.security_manager import AirflowSecurityManagerV2

if TYPE_CHECKING:
from airflow.auth.managers.models.base_user import BaseUser
Expand Down Expand Up @@ -114,13 +111,6 @@ def auth_manager():
return EmptyAuthManager(None)


@pytest.fixture
def auth_manager_with_appbuilder():
flask_app = Flask(__name__)
appbuilder = init_appbuilder(flask_app)
return EmptyAuthManager(appbuilder)


class TestBaseAuthManager:
def test_get_cli_commands_return_empty_list(self, auth_manager):
assert auth_manager.get_cli_commands() == []
Expand Down Expand Up @@ -238,9 +228,11 @@ def test_batch_is_authorized_variable(
)
assert result == expected

@pytest.mark.db_test
def test_security_manager_return_default_security_manager(self, auth_manager_with_appbuilder):
assert isinstance(auth_manager_with_appbuilder.security_manager, AirflowSecurityManagerV2)
@patch("airflow.www.security_manager.AirflowSecurityManagerV2")
def test_security_manager_return_default_security_manager(
self, mock_airflow_security_manager, auth_manager
):
assert auth_manager.security_manager == mock_airflow_security_manager()

@pytest.mark.parametrize(
"access_all, access_per_dag, dag_ids, expected",
Expand Down